Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitch292/1237 fix test cases #1410

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

mitch292
Copy link
Contributor

@mitch292 mitch292 commented Feb 8, 2025

The goal of this PR is to get the tests in the builds back in working order. It only partially resolves issue #1237.

There were essentially 3 types of cert updates done.

  1. Files that were copy pastes of our cf-ssl-trust, we could potentially automate this in the future
  2. mTLS test case data where scripts were available for regenerating the certs
  3. Extending a test CA cert via openssl that had the key in the repo.

@mitch292 mitch292 self-assigned this Feb 8, 2025
@mitch292 mitch292 marked this pull request as draft February 8, 2025 22:00
@mitch292 mitch292 force-pushed the mitch292/1237-fix-test-cases branch 9 times, most recently from 60de87b to 52b0dc1 Compare February 10, 2025 14:10
@mitch292 mitch292 force-pushed the mitch292/1237-fix-test-cases branch from 52b0dc1 to faaff55 Compare February 10, 2025 18:27
@mitch292 mitch292 changed the title [DNM] Mitch292/1237 fix test cases Mitch292/1237 fix test cases Feb 10, 2025
@mitch292 mitch292 marked this pull request as ready for review February 10, 2025 18:45
@nickysemenza
Copy link
Contributor

nice

@mitch292 mitch292 merged commit 1c1bc0b into cloudflare:master Feb 11, 2025
4 of 5 checks passed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (aa40f70) to head (faaff55).
Report is 35 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #1410       +/-   ##
==========================================
- Coverage   52.92%       0   -52.93%     
==========================================
  Files          76       0       -76     
  Lines        9169       0     -9169     
==========================================
- Hits         4853       0     -4853     
+ Misses       3843       0     -3843     
+ Partials      473       0      -473     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants